Subject: [Boost-commit] svn:boost r85322 - in trunk: libs/conversion/test status
From: antoshkka_at_[hidden]
Date: 2013-08-12 12:06:59
Author: apolukhin
Date: 2013-08-12 12:06:59 EDT (Mon, 12 Aug 2013)
New Revision: 85322
URL: http://svn.boost.org/trac/boost/changeset/85322
Log:
Update explicit failures markup and lexical_cast_float_types_test.cpp: do not run some checks when libc++ is used, but do expect other checks to pass well.
Text files modified:
trunk/libs/conversion/test/lexical_cast_float_types_test.cpp | 6 +++++-
trunk/status/explicit-failures-markup.xml | 11 -----------
2 files changed, 5 insertions(+), 12 deletions(-)
Modified: trunk/libs/conversion/test/lexical_cast_float_types_test.cpp
==============================================================================
--- trunk/libs/conversion/test/lexical_cast_float_types_test.cpp Mon Aug 12 10:56:38 2013 (r85321)
+++ trunk/libs/conversion/test/lexical_cast_float_types_test.cpp 2013-08-12 12:06:59 EDT (Mon, 12 Aug 2013) (r85322)
@@ -297,12 +297,16 @@
BOOST_CHECK_CLOSE_FRACTION(maxvalue, lexical_cast<test_t>(maxvalue), (std::numeric_limits<test_t>::epsilon()));
BOOST_CHECK_CLOSE_FRACTION(maxvalue, lexical_cast<test_t>(s_max_value), (std::numeric_limits<test_t>::epsilon()));
+#ifndef _LIBCPP_VERSION
+ // libc++ had a bug in implementation of stream conversions for values that must be represented as infinity.
+ // http://llvm.org/bugs/show_bug.cgi?id=15723#c4
BOOST_CHECK_THROW(lexical_cast<test_t>(s_max_value+"1"), bad_lexical_cast);
BOOST_CHECK_THROW(lexical_cast<test_t>(s_max_value+"9"), bad_lexical_cast);
- // VC9 can fail the fllowing tests on floats and doubles when using stingstream...
+ // VC9 can fail the following tests on floats and doubles when using stingstream...
BOOST_CHECK_THROW(lexical_cast<test_t>("1"+s_max_value), bad_lexical_cast);
BOOST_CHECK_THROW(lexical_cast<test_t>("9"+s_max_value), bad_lexical_cast);
+#endif
if ( is_same<test_t,float>::value )
{
Modified: trunk/status/explicit-failures-markup.xml
==============================================================================
--- trunk/status/explicit-failures-markup.xml Mon Aug 12 10:56:38 2013 (r85321)
+++ trunk/status/explicit-failures-markup.xml 2013-08-12 12:06:59 EDT (Mon, 12 Aug 2013) (r85322)
@@ -690,17 +690,6 @@
</test>
<test name="lexical_cast_float_types_test">
<mark-failure>
- <toolset name="clang-darwin-11"/>
- <toolset name="clang-darwin-tot11"/>
- <toolset name="clang-3.2~c++11_libc++"/>
- <note author="Antony Polukhin">
- libc++ had a bug in implementation of srteam conversions for
- values that shall be represented as infinity.
- </note>
- </mark-failure>
- </test>
- <test name="lexical_cast_float_types_test">
- <mark-failure>
<toolset name="vacpp-*"/>
<toolset name="vacpp"/>
<toolset name="msvc-9.0~stlport5.2"/>