Re: [Bloom] review starts on 13th of May

From: Joaquin M López Muñoz (joaquinlopezmunoz_at_[hidden])
Date: 2025-05-22 07:01:50

El 21/05/2025 a las 21:52, Christian Mazakas via Boost escribió:
> I vote to ACCEPT this library.
>
> First and foremost, a Bloom filter is a true return to form for Boost,
> implementing a classic data structure from computer science.
>
> Second, it has broadly understood practical use-cases already adopted by
> industry.
>
> Third, it was written by one Joaquín M López Muñoz who I'd say is one of
> the best container authors I've ever had the joys to work with.
>
> The documentation is nice and clear, explaining the application of the
> container and then the backing theory.
>
> Choosing a filter can seem a bit daunting but the docs do a good job here
> guiding users through it. And I'm sure the defaults are sufficient for the
> majority of users anyway.
>
> The implementation is robust and also vector-optimized. The presented
> benchmarks showcase the advantages of using the Bloom filter once you hit a
> certain element count, which is fantastic.
>
> So it seems to me like all we have here is a well-understood data structure
> with an incredibly high-quality implementation being presented to us. Seems
> like an easy acceptance vote to me.

Hi Christian, thank you for your review!

Joaquin M Lopez Munoz