From: pbristow_at_[hidden]
Date: 2020-09-18 08:19:05
> -----Original Message-----
> From: Boost <boost-bounces_at_[hidden]> On Behalf Of Pranam Lashkari via Boost
> Sent: 14 September 2020 08:30
> To: boost <boost_at_[hidden]>
> Cc: Pranam Lashkari <plashkari628_at_[hidden]>
> Subject: [boost] [review][JSON] Review of JSON starts today: Sept 14 - Sept 23
>
> Boost formal review of Vinnie Falco and Krystian Stasiowski's library JSON starts today and will run for 10
> days ending on 23 Sept 2020. Both of these authors have already developed a couple of libraries which
> are accepted in Boost(boost beast and Static String)
>
> This library focuses on a common and popular use-case for JSON. It provides a container to hold parsed
> and serialised JSON types. It provides more flexibility and better benchmark performance than its
> competitors.
>
> JSON highlights the following features in the documentation:
>
> - Fast compilation
> - Require only C++11
> - Fast streaming parser and serializer
> - Easy and safe API with allocator support
> - Constant-time key lookup for objects
> - Options to allow non-standard JSON
> - Compile without Boost, define BOOST_JSON_STANDALONE
> - Optional header-only, without linking to a library
What I knew about JSON could have be written on a postage stamp, but I have at least read the documentation.
It is an example of how it should be done. It has good examples and good reference info. I could quickly see how to use it, but didn't have a need, and didn't feel it useful as others already have, and there are benchmarks too.
On that basis alone, my view is ACCEPT, FWIW.
> (a point I would like to add in highlight: it has cool Jason logo ðŸ˜)
(😠indeed - My only recommendation is to replace this with a Boost logo ASAP ! No - more than that - I make it a condition for acceptance.)
Paul
PS That there are other libraries doing similar (but fairly different) things is no reason to reject this library.