Subject: Re: [boost] [Boost.Yap] Review results
From: Zach Laine (whatwasthataddress_at_[hidden])
Date: 2018-03-04 20:38:21
On Fri, Mar 2, 2018 at 12:16 AM, Louis Dionne via Boost <
boost_at_[hidden]> wrote:
> Dear Boost,
>
> I am pleased to announce that the Yap library is CONDITIONALLY ACCEPTED
> into Boost. I counted the following formal reviews:
>
[snip]
> Based on the concerns above, the following lists the conditions for
> acceptance:
>
> - Documentation
> In my opinion, this was the biggest concern to be addressed. A lot of
> progress was made during and after the review, but I still think the
> documentation can be improved and made more complete. I especially
> believe that integrating more examples inside the "tutorial" (not just
> at the end) and introducing new concepts more gradually would help
> readers
> that are not already expression template gurus. It is very difficult to
> set a clear action item for "improving the documentation". For this
> reason,
> Brook Milligan and I will work with Zach to define what it means for
> the
> documentation to meet this acceptance condition. Brook was kind enough
> to
> agree to this when I asked him in a private communication.
>
> - A single macro for symmetric binary operators
> The library must provide a way to define symmetric binary operators in
> one go. Exactly how this can be achieved and whether we should be able
> to SFINAE-constrain the arguments is left to Zach's discretion.
>
> - External dependencies
> The external dependencies must not be packaged with the library itself.
> Another mechanism should be used; I leave that mechanism unspecified,
> but it should be possible to test the library using the usual
> Boost.Build
> workflow (e.g. an ExternalPackage download that would only work in
> CMake
> is not acceptable).
>
> - Boost.Build
> Yap needs to support Boost.Build like all the other Boost libraries.
>
These conditions are now satisfied, modulo bugs. In particular, if anyone
wants to have a look, the new docs are at the same URL as before:
Zach