Subject: Re: [boost] [mpl] Can I merge pull requests for 'develop' into 'master' for Boost 1.56
From: Edward Diener (eldiener_at_[hidden])
Date: 2014-07-09 17:44:10
On 7/9/2014 12:51 PM, Eric Niebler wrote:
> On 07/09/2014 09:04 AM, Edward Diener wrote:
>> I had not merged your first change from 'develop' to 'master' and I am
>> sure that is correct, since I tested it with VC++. I have VC8 through
>> the latest VC12 I test against.
>>
>> Were you able to test your second change and how did you do it, since
>> there is no toolset for CUDA AFAICS ? I assume you figured out a command
>> line to pass to the CUDA compiler if you tested it.
>
> I'm working on a cross-platform project that uses CUDA and Boost. I use
> CMake to find CUDA and build the .cu files. It generates the command
> line. It's a black box as far as I'm concerned. Everything worked on
> Linux and Windows before my first change, broke on Windows after my
> first change, and works again after my second change.
>
>> If it is alright to merge these changes to 'master' should I tell
>> Marshall Clow after it has been done ?
>
> I'm sure it'll get picked up eventually. *Lots* of important changes
> will be made before the beta and the final release. I'm not worries
> about this getting dropped.
I have pushed your changes to mpl 'master' after checking them out once
again against VC8 through VC12.