Subject: Re: [boost] [mpl] Can I merge pull requests for 'develop' into 'master' for Boost 1.56
From: Daniel James (dnljms_at_[hidden])
Date: 2014-07-09 04:43:46
On 9 July 2014 07:04, Eric Niebler <eniebler_at_[hidden]> wrote:
> On 07/07/2014 05:30 PM, Edward Diener wrote:
>> Eric Niebler has issued a couple of pull requests for MPL on 'develop'
>> involving VC++ and the has_xxx functionality which I have merged to
>> 'develop' after testing them locally and successfully with various
>> versions of VC++ from VC8 to VC12. The earlier already cycled through
>> regression tests successfully but the latest was merged just recently.
>> The latest involves a change for the NVidia CUDA compiler, for which I
>> see no regression testing. I have not tested this change with the CUDA
>> compiler ( is there even a Boost Build toolset for this compiler ? ) but
>> I implictly trust Eric's judgment.
>>
>> Can/should these changes be merged to 'master' for 1.56 ?
>
> Well, I'm a release manager, and I think it's ok. I admit I'm biased and
> should probably recuse myself. Maybe one of the other release managers
> could chime in?
Is CUDA emulating Visual C++? If it is, then you should use _MSC_VER
rather than BOOST_MSVC, otherwise it will break again if config ever
gets CUDA support. Do you know if it works with CUDA on other
platforms?