Subject: Re: [boost] [git] Line endings in bootstrap.bat on Windows
From: Dave Abrahams (dave_at_[hidden])
Date: 2013-11-27 10:55:23


Gavin Lambert <gavinl_at_[hidden]> writes:

> On 27/11/2013 16:54, Quoth Dave Abrahams:
>> Gavin Lambert <gavinl_at_[hidden]> writes:
>>> You should only run into trouble if the repository is not LF-only or
>>> if your checkout contains mixed-EOL files, either from using editors
>>> that altered EOLs (which will be common on Windows if you don't have
>>> autocrlf=true) or from changing the autocrlf setting after checking
>>> out.
>>>
>>> If the conversion is not already normalising line endings to LFs,
>>> perhaps it should do so? (With some exceptions for test files
>>> specifically for specific EOL handling, if any.)
>>>
>>>
>>> [1] https://help.github.com/articles/dealing-with-line-endings
>>> [2] http://git-scm.com/book/ch7-1.html#Formatting-and-Whitespace
>>
>> The conversion represents the file contents from SVN losslessly.
>
> If by that you mean that you are not converting text files to LF-only

We are not.

>
> (or letting git do that for you via eol=lf or via running the
> conversion on Windows),

Git doesn't do any conversion in the repository. It can do some
conversions at checkout time.

> then this is probably the problem.
>
> Converting text files to LF-only is also lossless, as long as they
> really are text files (and you're not relying on the particular EOL
> format for eg. some test case).

No, it's not lossless. A lossless conversion is reversible. Dropping
CRs is clearly not.

By the way, some of the files have intentional mixes of CR and LF for
testing purposes.