Subject: Re: [boost] [Release managers] Permission to rollback Boost.Thread breaking changes
From: Vicente J. Botet Escriba (vicente.botet_at_[hidden])
Date: 2013-01-02 18:48:30
Le 02/01/13 18:51, Daniel James a écrit :
> On 2 January 2013 17:24, Vicente J. Botet Escriba
> <vicente.botet_at_[hidden]> wrote:
>> Le 02/01/13 16:10, Daniel James a écrit :
>>
>>> If vacpp isn't supported, then it should be marked up as such.
>> This platform was supported and now it fails without error
> Ah, right. Maybe try asking on the testing list sometime?
>
>> I have fixed it as for
>> https://svn.boost.org/trac/boost/changeset/82311. The problem is that config
>> file doesn't defines BOOST_NO_CXX11_HDR_INITIALIZER_LIST for gcc 4.4 and 4.5
>> even if the feature is incomplete as the private overload is taken instead
>> of the initializer list overload. The tester that have run after this change
>> show that there is no error anymore.
> OK, I see, I'm not totally up to date on the unified initialization
> stuff. I think you should be using the
> BOOST_NO_CXX11_UNIFIED_INITIALIZATION_SYNTAX macro in addition to
> BOOST_NO_CXX11_HDR_INITIALIZER_LIST, rather than checking the gcc
> version.
>
Thanks,
I will try it.
>> Fixed already with https://svn.boost.org/trac/boost/changeset/82317. See
>> tester teeks99-1a-win7-32on64
>> <http://www.boost.org/development/tests/trunk/teeks99-1a-win7-32on64.html>.
>>
>> It is OK to merge both fixes?
> No, wait until the beta is out. I was just going through the test
> results to see if there was any reason not to merge.
>
>
No problem. I will prepare a new patch with your suggestion once the
regression test pass for these versions.
Best,
Vicente