Subject: Re: [boost] [numeric] Adding numeric_cast_traits.hpp on 08/11 (today) breaks trunk
From: Edward Diener (eldiener_at_[hidden])
Date: 2011-08-12 09:59:24
On 8/12/2011 8:20 AM, Brandon Kohn wrote:
> On 8/12/2011 2:57 AM, Daniel James wrote:
>> On 12 August 2011 03:43, Edward Diener<eldiener_at_[hidden]> wrote:
>>> These changes need to be fixed or reverted. Too many things depend on
>>> numeric_cast for this to remain broken.
>>
>> I checked in a quick fix. Hopefully I haven't stepped on anyone's toes.
>
> Thanks :). I'm looking at the fix and don't understand why #elif was
> breaking there. I did my compiles on msvc-10 and gcc-4.3.4/cygwin with
> no issues.
The failure I saw occured on msvc-10.0 as well as gcc-4.6.0 so you
should revisit your tests so that they catch such a failure.
Daniel James' update fixed the problem but tests should show the problem
in the first place.