Subject: Re: [boost] [gsoc] Request Feedback for Boost.Ustr Unicode String Adapter
From: Phil Endecott (spam_from_boost_dev_at_[hidden])
Date: 2011-08-11 10:15:30


Soares Chen Ruo Fei wrote:
> you can assume the class to have the
> following signature with identical functionality:
>
> <typename StringT>
> class unicode_string_adapter : public std::shared_ptr<const StringT>;

What is your rationale for that? What precedent is there for a
wrapper/adapter/facade that behaves like a pointer to the wrapped
object? I'm not aware of any precedents; this is a new pattern to me.
Why have you chosen to do this, rather than providing an accessor
member like impl()?

Regards, Phil.