Subject: Re: [boost] [locale] Review
From: Mathias Gaunard (mathias.gaunard_at_[hidden])
Date: 2011-04-19 15:24:22
On 19/04/2011 17:27, Steven Watanabe wrote:
> AMDG
>
> On 04/19/2011 08:13 AM, Mathias Gaunard wrote:
>> On 18/04/2011 14:24, Artyom wrote:
>>
>>>
>>>> some compile-time values tested at runtime,
>>>> some things that could have reused existing
>>>> utilities from Boost,
>>>
>>> More specific points?
>>
>> I saw stuff like
>>
>> if(is_linear_iterator<SomeType>::is_linear)
>> ....
>>
>
> And what exactly is wrong with this?
> Most compilers are perfectly capable of
> optimizing away the branch, and it makes
> the code more straightforward than any
> compile time selection mechanism.
True, it's a style thing, but the fact that there were several issues
with this single line caught my eye.