Subject: Re: [boost] [Process] List of small issues
From: Boris Schaeling (boris_at_[hidden])
Date: 2011-01-16 16:23:51
On Thu, 13 Jan 2011 15:35:53 +0100, Artyom <artyomtnk_at_[hidden]> wrote:
> [...]- stream buffer implementation:
Thanks, I'll update the code! If you have any ideas how a test case could
look like to verify the fix let me know (given that there is no mocking
framework in Boost yet).
> - Windows and Unicode.
> [...] 1. You can also always assume that strings under windows are
> UTF-8
> and always convert them to wide string before system calls.
> This is I think better approach, but it is different from what
> most of boost does.
>
> 2. I do not recommend adding wide API - makes the code much uglier,
> rather convert normal strigns to wide strings before system call.
I'd appreciate a Boost-wide solution or guideline. And I think this thread
has already turned into a Unicode discussion? :) The interface of
Boost.Process in that aspect has definitely evolved without clear
direction - I think neither I nor other Boost.Process developers spent
time trying to solve this problem in this library.
> - It may be very good addition to implement full support of putback.
If you have a patch just drop me a mail! :)
> [...]P.S.: Good luck with the review library looks overall very nice.
Thanks! I have some more patches waiting to be applied. There will be
definitely another update (of the implementation only) before the review
starts.
Boris