Subject: Re: [boost] [gil io_new review] Reading images from in-memorysources
From: Christian Henning (chhenning_at_[hidden])
Date: 2010-12-07 15:26:07
Hi there,
On Tue, Dec 7, 2010 at 12:45 PM, Domagoj Saric <dsaritz_at_[hidden]> wrote:
>
> "Christian Henning" <chhenning_at_[hidden]> wrote in message
> news:AANLkTik=kNJT2zBinixfgLpq3dvB7_nVDkEKw4ghr8oq_at_mail.gmail.com...
>>
>> There is a function called use_merged_upsample which returns only true
>> when UPSAMPLE_MERGING_SUPPORTED is set during compilation. Otherwise
>>
>> cinfo->rec_outbuf_height = 1;
>>
>> That's the only assignment I can find in the whole libjpeg source
>> code. Maybe I'm missing something?
>
> If I understood Phil correctly, he meant reading scanlines in packs like
> this:
> http://svn.boost.org/svn/boost/sandbox/gil/boost/gil/extension/io2/libjpeg_image.hpp
> (search for rec_outbuf_height in function raw_convert_to_prepared_view())...
>
To make sure we are on the same page. You refer to rec_outbuf_height
only once, inside a BOOST_ASSERT statement, correct?
But Phil's point is taken and will be incorporated into the final version.
Regards,
Christian